Skip to content

Commit

Permalink
Merge branch irq/irqchip-spurious-printk into irq/irqchip-next
Browse files Browse the repository at this point in the history
Drop a whole bunch of unnecessary printks on error paths

* irq/irqchip-spurious-printk:
  irqchip: gic-pm: Remove redundant error log of clock bulk
  irqchip/sun4i: Remove unnecessary oom message
  irqchip/irq-imx-gpcv2: Remove unnecessary oom message
  irqchip/imgpdc: Remove unnecessary oom message
  irqchip/gic-v3-its: Remove unnecessary oom message
  irqchip/gic-v2m: Remove unnecessary oom message
  irqchip/exynos-combiner: Remove unnecessary oom message
  • Loading branch information
Marc Zyngier committed Jun 11, 2021
2 parents 8124c8a + 21a4961 commit 525ea1b
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 30 deletions.
4 changes: 1 addition & 3 deletions drivers/irqchip/exynos-combiner.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,8 @@ static void __init combiner_init(void __iomem *combiner_base,
nr_irq = max_nr * IRQ_IN_COMBINER;

combiner_data = kcalloc(max_nr, sizeof (*combiner_data), GFP_KERNEL);
if (!combiner_data) {
pr_warn("%s: could not allocate combiner data\n", __func__);
if (!combiner_data)
return;
}

combiner_irq_domain = irq_domain_add_linear(np, nr_irq,
&combiner_irq_domain_ops, combiner_data);
Expand Down
4 changes: 1 addition & 3 deletions drivers/irqchip/irq-gic-pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,8 @@ static int gic_runtime_resume(struct device *dev)
int ret;

ret = clk_bulk_prepare_enable(data->num_clocks, chip_pm->clks);
if (ret) {
dev_err(dev, "clk_enable failed: %d\n", ret);
if (ret)
return ret;
}

/*
* On the very first resume, the pointer to chip_pm->chip_data
Expand Down
4 changes: 1 addition & 3 deletions drivers/irqchip/irq-gic-v2m.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,10 +323,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode,
struct v2m_data *v2m;

v2m = kzalloc(sizeof(struct v2m_data), GFP_KERNEL);
if (!v2m) {
pr_err("Failed to allocate struct v2m_data.\n");
if (!v2m)
return -ENOMEM;
}

INIT_LIST_HEAD(&v2m->entry);
v2m->fwnode = fwnode;
Expand Down
8 changes: 2 additions & 6 deletions drivers/irqchip/irq-gic-v3-its.c
Original file line number Diff line number Diff line change
Expand Up @@ -4895,10 +4895,8 @@ static int its_init_vpe_domain(void)
entries = roundup_pow_of_two(nr_cpu_ids);
vpe_proxy.vpes = kcalloc(entries, sizeof(*vpe_proxy.vpes),
GFP_KERNEL);
if (!vpe_proxy.vpes) {
pr_err("ITS: Can't allocate GICv4 proxy device array\n");
if (!vpe_proxy.vpes)
return -ENOMEM;
}

/* Use the last possible DevID */
devid = GENMASK(device_ids(its) - 1, 0);
Expand Down Expand Up @@ -5314,10 +5312,8 @@ static void __init acpi_table_parse_srat_its(void)

its_srat_maps = kmalloc_array(count, sizeof(struct its_srat_map),
GFP_KERNEL);
if (!its_srat_maps) {
pr_warn("SRAT: Failed to allocate memory for its_srat_maps!\n");
if (!its_srat_maps)
return;
}

acpi_table_parse_entries(ACPI_SIG_SRAT,
sizeof(struct acpi_table_srat),
Expand Down
8 changes: 2 additions & 6 deletions drivers/irqchip/irq-imgpdc.c
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,8 @@ static int pdc_intc_probe(struct platform_device *pdev)

/* Allocate driver data */
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
if (!priv) {
dev_err(&pdev->dev, "cannot allocate device data\n");
if (!priv)
return -ENOMEM;
}
raw_spin_lock_init(&priv->lock);
platform_set_drvdata(pdev, priv);

Expand Down Expand Up @@ -356,10 +354,8 @@ static int pdc_intc_probe(struct platform_device *pdev)
/* Get peripheral IRQ numbers */
priv->perip_irqs = devm_kcalloc(&pdev->dev, 4, priv->nr_perips,
GFP_KERNEL);
if (!priv->perip_irqs) {
dev_err(&pdev->dev, "cannot allocate perip IRQ list\n");
if (!priv->perip_irqs)
return -ENOMEM;
}
for (i = 0; i < priv->nr_perips; ++i) {
irq = platform_get_irq(pdev, 1 + i);
if (irq < 0)
Expand Down
4 changes: 1 addition & 3 deletions drivers/irqchip/irq-imx-gpcv2.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node,
}

cd = kzalloc(sizeof(struct gpcv2_irqchip_data), GFP_KERNEL);
if (!cd) {
pr_err("%pOF: kzalloc failed!\n", node);
if (!cd)
return -ENOMEM;
}

raw_spin_lock_init(&cd->rlock);

Expand Down
8 changes: 2 additions & 6 deletions drivers/irqchip/irq-sun4i.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,8 @@ static int __init sun4i_ic_of_init(struct device_node *node,
struct device_node *parent)
{
irq_ic_data = kzalloc(sizeof(struct sun4i_irq_chip_data), GFP_KERNEL);
if (!irq_ic_data) {
pr_err("kzalloc failed!\n");
if (!irq_ic_data)
return -ENOMEM;
}

irq_ic_data->enable_reg_offset = SUN4I_IRQ_ENABLE_REG_OFFSET;
irq_ic_data->mask_reg_offset = SUN4I_IRQ_MASK_REG_OFFSET;
Expand All @@ -164,10 +162,8 @@ static int __init suniv_ic_of_init(struct device_node *node,
struct device_node *parent)
{
irq_ic_data = kzalloc(sizeof(struct sun4i_irq_chip_data), GFP_KERNEL);
if (!irq_ic_data) {
pr_err("kzalloc failed!\n");
if (!irq_ic_data)
return -ENOMEM;
}

irq_ic_data->enable_reg_offset = SUNIV_IRQ_ENABLE_REG_OFFSET;
irq_ic_data->mask_reg_offset = SUNIV_IRQ_MASK_REG_OFFSET;
Expand Down

0 comments on commit 525ea1b

Please sign in to comment.