Skip to content

Commit

Permalink
net: ipa: determine the maximum endpoint ID
Browse files Browse the repository at this point in the history 
Each endpoint ID has an entry in the IPA endpoint array.  But the
size of that array is defined at compile time.  Instead, rename
ipa_endpoint_data_valid() to be ipa_endpoint_max() and have it
return the maximum endpoint ID defined in configuration data.
That function will still validate configuration data.

Zero is returned on error; it's a valid endpoint ID, but we need
more than one, so it can't be the maximum.  The next patch makes use
of the returned maximum value.

Finally, rename the "initialized" mask of endpoints defined by
configuration data to be "defined".

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Alex Elder authored and Jakub Kicinski committed Oct 29, 2022
1 parent e359ba8 commit 5274c71
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 34 deletions.
6 changes: 3 additions & 3 deletions drivers/net/ipa/ipa.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ struct ipa_interrupt;
* @zero_addr: DMA address of preallocated zero-filled memory
* @zero_virt: Virtual address of preallocated zero-filled memory
* @zero_size: Size (bytes) of preallocated zero-filled memory
* @defined: Bit mask indicating endpoints defined in config data
* @available: Bit mask indicating endpoints hardware supports
* @filter_map: Bit mask indicating endpoints that support filtering
* @initialized: Bit mask indicating endpoints initialized
* @set_up: Bit mask indicating endpoints set up
* @enabled: Bit mask indicating endpoints enabled
* @modem_tx_count: Number of defined modem TX endoints
Expand Down Expand Up @@ -117,9 +117,9 @@ struct ipa {
size_t zero_size;

/* Bit masks indicating endpoint state */
u32 available; /* supported by hardware */
u32 defined; /* Defined in configuration data */
u32 available; /* Supported by hardware */
u32 filter_map;
u32 initialized;
u32 set_up;
u32 enabled;

Expand Down
67 changes: 36 additions & 31 deletions drivers/net/ipa/ipa_endpoint.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -243,42 +243,47 @@ static bool ipa_endpoint_data_valid_one(struct ipa *ipa, u32 count,
return true;
}

static bool ipa_endpoint_data_valid(struct ipa *ipa, u32 count,
const struct ipa_gsi_endpoint_data *data)
/* Validate endpoint configuration data. Return max defined endpoint ID */
static u32 ipa_endpoint_max(struct ipa *ipa, u32 count,
const struct ipa_gsi_endpoint_data *data)
{
const struct ipa_gsi_endpoint_data *dp = data;
struct device *dev = &ipa->pdev->dev;
enum ipa_endpoint_name name;
u32 max;

if (count > IPA_ENDPOINT_COUNT) {
dev_err(dev, "too many endpoints specified (%u > %u)\n",
count, IPA_ENDPOINT_COUNT);
return false;
return 0;
}

/* Make sure needed endpoints have defined data */
if (ipa_gsi_endpoint_data_empty(&data[IPA_ENDPOINT_AP_COMMAND_TX])) {
dev_err(dev, "command TX endpoint not defined\n");
return false;
return 0;
}
if (ipa_gsi_endpoint_data_empty(&data[IPA_ENDPOINT_AP_LAN_RX])) {
dev_err(dev, "LAN RX endpoint not defined\n");
return false;
return 0;
}
if (ipa_gsi_endpoint_data_empty(&data[IPA_ENDPOINT_AP_MODEM_TX])) {
dev_err(dev, "AP->modem TX endpoint not defined\n");
return false;
return 0;
}
if (ipa_gsi_endpoint_data_empty(&data[IPA_ENDPOINT_AP_MODEM_RX])) {
dev_err(dev, "AP<-modem RX endpoint not defined\n");
return false;
return 0;
}

for (name = 0; name < count; name++, dp++)
max = 0;
for (name = 0; name < count; name++, dp++) {
if (!ipa_endpoint_data_valid_one(ipa, count, data, dp))
return false;
return 0;
max = max_t(u32, max, dp->endpoint_id);
}

return true;
return max;
}

/* Allocate a transaction to use on a non-command endpoint */
Expand Down Expand Up @@ -448,7 +453,7 @@ void ipa_endpoint_modem_pause_all(struct ipa *ipa, bool enable)
/* Reset all modem endpoints to use the default exception endpoint */
int ipa_endpoint_modem_exception_reset_all(struct ipa *ipa)
{
u32 initialized = ipa->initialized;
u32 defined = ipa->defined;
struct gsi_trans *trans;
u32 count;

Expand All @@ -463,13 +468,13 @@ int ipa_endpoint_modem_exception_reset_all(struct ipa *ipa)
return -EBUSY;
}

while (initialized) {
u32 endpoint_id = __ffs(initialized);
while (defined) {
u32 endpoint_id = __ffs(defined);
struct ipa_endpoint *endpoint;
const struct ipa_reg *reg;
u32 offset;

initialized ^= BIT(endpoint_id);
defined ^= BIT(endpoint_id);

/* We only reset modem TX endpoints */
endpoint = &ipa->endpoint[endpoint_id];
Expand Down Expand Up @@ -1812,13 +1817,13 @@ static void ipa_endpoint_teardown_one(struct ipa_endpoint *endpoint)

void ipa_endpoint_setup(struct ipa *ipa)
{
u32 initialized = ipa->initialized;
u32 defined = ipa->defined;

ipa->set_up = 0;
while (initialized) {
u32 endpoint_id = __ffs(initialized);
while (defined) {
u32 endpoint_id = __ffs(defined);

initialized ^= BIT(endpoint_id);
defined ^= BIT(endpoint_id);

ipa_endpoint_setup_one(&ipa->endpoint[endpoint_id]);
}
Expand All @@ -1842,10 +1847,10 @@ int ipa_endpoint_config(struct ipa *ipa)
{
struct device *dev = &ipa->pdev->dev;
const struct ipa_reg *reg;
u32 initialized;
u32 tx_count;
u32 rx_count;
u32 rx_base;
u32 defined;
u32 limit;
u32 val;

Expand Down Expand Up @@ -1885,12 +1890,12 @@ int ipa_endpoint_config(struct ipa *ipa)
/* Mark all supported RX and TX endpoints as available */
ipa->available = GENMASK(limit - 1, rx_base) | GENMASK(tx_count - 1, 0);

initialized = ipa->initialized;
while (initialized) {
u32 endpoint_id = __ffs(initialized);
defined = ipa->defined;
while (defined) {
u32 endpoint_id = __ffs(defined);
struct ipa_endpoint *endpoint;

initialized ^= BIT(endpoint_id);
defined ^= BIT(endpoint_id);

if (endpoint_id >= limit) {
dev_err(dev, "invalid endpoint id, %u > %u\n",
Expand Down Expand Up @@ -1943,24 +1948,24 @@ static void ipa_endpoint_init_one(struct ipa *ipa, enum ipa_endpoint_name name,
endpoint->toward_ipa = data->toward_ipa;
endpoint->config = data->endpoint.config;

ipa->initialized |= BIT(endpoint->endpoint_id);
ipa->defined |= BIT(endpoint->endpoint_id);
}

static void ipa_endpoint_exit_one(struct ipa_endpoint *endpoint)
{
endpoint->ipa->initialized &= ~BIT(endpoint->endpoint_id);
endpoint->ipa->defined &= ~BIT(endpoint->endpoint_id);

memset(endpoint, 0, sizeof(*endpoint));
}

void ipa_endpoint_exit(struct ipa *ipa)
{
u32 initialized = ipa->initialized;
u32 defined = ipa->defined;

while (initialized) {
u32 endpoint_id = __fls(initialized);
while (defined) {
u32 endpoint_id = __fls(defined);

initialized ^= BIT(endpoint_id);
defined ^= BIT(endpoint_id);

ipa_endpoint_exit_one(&ipa->endpoint[endpoint_id]);
}
Expand All @@ -1977,10 +1982,10 @@ u32 ipa_endpoint_init(struct ipa *ipa, u32 count,

BUILD_BUG_ON(!IPA_REPLENISH_BATCH);

if (!ipa_endpoint_data_valid(ipa, count, data))
if (!ipa_endpoint_max(ipa, count, data))
return 0; /* Error */

ipa->initialized = 0;
ipa->defined = 0;

filter_map = 0;
for (name = 0; name < count; name++, data++) {
Expand Down

0 comments on commit 5274c71

Please sign in to comment.