Skip to content

Commit

Permalink
compat: add a compat_need_64bit_alignment_fixup() helper
Browse files Browse the repository at this point in the history
Add a helper to check if the calling syscall needs a fixup for
non-natural 64-bit type alignment in the compat ABI.  This will only
return true for i386 syscalls on x86_64.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Christoph Hellwig authored and Al Viro committed Sep 17, 2020
1 parent cc7886d commit 527c412
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions arch/x86/include/asm/compat.h
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ static inline bool in_compat_syscall(void)
return in_32bit_syscall();
}
#define in_compat_syscall in_compat_syscall /* override the generic impl */
#define compat_need_64bit_alignment_fixup in_ia32_syscall
#endif

struct compat_siginfo;
Expand Down
9 changes: 9 additions & 0 deletions include/linux/compat.h
Original file line number Diff line number Diff line change
Expand Up @@ -932,6 +932,15 @@ static inline bool in_compat_syscall(void) { return false; }

#endif /* CONFIG_COMPAT */

/*
* Some legacy ABIs like the i386 one use less than natural alignment for 64-bit
* types, and will need special compat treatment for that. Most architectures
* don't need that special handling even for compat syscalls.
*/
#ifndef compat_need_64bit_alignment_fixup
#define compat_need_64bit_alignment_fixup() false
#endif

/*
* A pointer passed in from user mode. This should not
* be used for syscall parameters, just declare them
Expand Down

0 comments on commit 527c412

Please sign in to comment.