Skip to content

Commit

Permalink
x86, boot: Remove multiple copy of static function sanitize_boot_para…
Browse files Browse the repository at this point in the history
…ms()

commit 8c5477e upstream.

Kernel build warns:
 'sanitize_boot_params' defined but not used [-Wunused-function]

at below files:
  arch/x86/boot/compressed/cmdline.c
  arch/x86/boot/compressed/error.c
  arch/x86/boot/compressed/early_serial_console.c
  arch/x86/boot/compressed/acpi.c

That's becausethey each include misc.h which includes a definition of
sanitize_boot_params() via bootparam_utils.h.

Remove the inclusion from misc.h and have the c file including
bootparam_utils.h directly.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/1563283092-1189-1-git-send-email-zhenzhong.duan@oracle.com
[nc: Fixed conflict around lack of 67b6662]
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Zhenzhong Duan authored and Greg Kroah-Hartman committed Sep 16, 2019
1 parent f935c94 commit 52b0d2e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions arch/x86/boot/compressed/misc.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include "misc.h"
#include "../string.h"
#include <asm/bootparam_utils.h>

/* WARNING!!
* This code is compiled with -fPIC and it is relocated dynamically
Expand Down
1 change: 0 additions & 1 deletion arch/x86/boot/compressed/misc.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include <asm/page.h>
#include <asm/boot.h>
#include <asm/bootparam.h>
#include <asm/bootparam_utils.h>

#define BOOT_BOOT_H
#include "../ctype.h"
Expand Down

0 comments on commit 52b0d2e

Please sign in to comment.