Skip to content

Commit

Permalink
Staging: vc04_services: Cleanup in ctrl_set_bitrate()
Browse files Browse the repository at this point in the history
Remove unnecessary variable from the function and make a corresponding
change w.r.t the variable. In addition to that align the parameters in
the parentheses to maintain Linux kernel coding style

Issue suggested by Coccinelle.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Madhumitha Prabakaran authored and Greg Kroah-Hartman committed Apr 25, 2019
1 parent 06e8c28 commit 52c4dfc
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions drivers/staging/vc04_services/bcm2835-camera/controls.c
Original file line number Diff line number Diff line change
Expand Up @@ -607,18 +607,15 @@ static int ctrl_set_bitrate(struct bm2835_mmal_dev *dev,
struct v4l2_ctrl *ctrl,
const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl)
{
int ret;
struct vchiq_mmal_port *encoder_out;

dev->capture.encode_bitrate = ctrl->val;

encoder_out = &dev->component[MMAL_COMPONENT_VIDEO_ENCODE]->output[0];

ret = vchiq_mmal_port_parameter_set(dev->instance, encoder_out,
mmal_ctrl->mmal_id,
&ctrl->val, sizeof(ctrl->val));
ret = 0;
return ret;
return vchiq_mmal_port_parameter_set(dev->instance, encoder_out,
mmal_ctrl->mmal_id, &ctrl->val,
sizeof(ctrl->val));
}

static int ctrl_set_bitrate_mode(struct bm2835_mmal_dev *dev,
Expand Down

0 comments on commit 52c4dfc

Please sign in to comment.