Skip to content

Commit

Permalink
Revert "oom: oom_kill_process: fix the child_points logic"
Browse files Browse the repository at this point in the history
This reverts the parent commit.  I hate doing that, but it's generating
some discussion ("half of it is right"), and since I am planning on
doing the 2.6.38 release later today we can punt it to stable if
required. Let's not rock the boat right now.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Linus Torvalds committed Mar 14, 2011
1 parent dc1b83a commit 52d3c03
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions mm/oom_kill.c
Original file line number Diff line number Diff line change
Expand Up @@ -458,10 +458,10 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
struct mem_cgroup *mem, nodemask_t *nodemask,
const char *message)
{
struct task_struct *victim;
struct task_struct *victim = p;
struct task_struct *child;
struct task_struct *t;
unsigned int victim_points;
struct task_struct *t = p;
unsigned int victim_points = 0;

if (printk_ratelimit())
dump_header(p, gfp_mask, order, mem, nodemask);
Expand All @@ -487,15 +487,10 @@ static int oom_kill_process(struct task_struct *p, gfp_t gfp_mask, int order,
* parent. This attempts to lose the minimal amount of work done while
* still freeing memory.
*/
victim_points = oom_badness(p, mem, nodemask, totalpages);
victim = p;
t = p;
do {
list_for_each_entry(child, &t->children, sibling) {
unsigned int child_points;

if (child->mm == t->mm)
continue;
/*
* oom_badness() returns 0 if the thread is unkillable
*/
Expand Down

0 comments on commit 52d3c03

Please sign in to comment.