Skip to content

Commit

Permalink
tools/nolibc: export environ as a weak symbol on i386
Browse files Browse the repository at this point in the history
The environ is retrieved from the _start code and is easy to store at
this moment. Let's declare the variable weak and store the value into
it. By not being static it will be visible to all units. By being weak,
if some programs already declared it, they will continue to be able to
use it. This was tested both with environ inherited from _start and
extracted from envp.

Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
  • Loading branch information
Willy Tarreau authored and Paul E. McKenney committed Jan 10, 2023
1 parent 89dc509 commit 52e423f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/include/nolibc/arch-i386.h
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ struct sys_stat_struct {
_eax; \
})

char **environ __attribute__((weak));

/* startup code */
/*
* i386 System V ABI mandates:
Expand All @@ -191,6 +193,7 @@ void __attribute__((weak,noreturn,optimize("omit-frame-pointer"))) _start(void)
"pop %eax\n" // argc (first arg, %eax)
"mov %esp, %ebx\n" // argv[] (second arg, %ebx)
"lea 4(%ebx,%eax,4),%ecx\n" // then a NULL then envp (third arg, %ecx)
"mov %ecx, environ\n" // save environ
"xor %ebp, %ebp\n" // zero the stack frame
"and $-16, %esp\n" // x86 ABI : esp must be 16-byte aligned before
"sub $4, %esp\n" // the call instruction (args are aligned)
Expand Down

0 comments on commit 52e423f

Please sign in to comment.