Skip to content

Commit

Permalink
MIPS: call ->smp_finish() a little late
Browse files Browse the repository at this point in the history
We have move irq enable to ->smp_finish. Place ->smp_finish() a little
late to prepare for move set_cpu_online() into start_secondary.
And it's not necessary to call cpu_set(cpu, cpu_callin_map) and
synchronise_count_slave() with irq enabled.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: David Daney <david.daney@cavium.com>
Acked-by: David Daney <david.daney@cavium.com>
Patchwork: https://patchwork.linux-mips.org/patch/3850/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Yong Zhang authored and Ralf Baechle committed Jul 19, 2012
1 parent 263afbd commit 5309bda
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion arch/mips/kernel/smp.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,14 @@ asmlinkage __cpuinit void start_secondary(void)

notify_cpu_starting(cpu);

mp_ops->smp_finish();
set_cpu_sibling_map(cpu);

cpu_set(cpu, cpu_callin_map);

synchronise_count_slave();

mp_ops->smp_finish();

cpu_idle();
}

Expand Down

0 comments on commit 5309bda

Please sign in to comment.