Skip to content

Commit

Permalink
virtio_console: fix order of fields cols and rows
Browse files Browse the repository at this point in the history
According to section 5.3.6.2 (Multiport Device Operation) of the virtio
spec(version 1.2) a control buffer with the event VIRTIO_CONSOLE_RESIZE
is followed by a virtio_console_resize struct containing cols then rows.
The kernel implements this the wrong way around (rows then cols) resulting
in the two values being swapped.

Signed-off-by: Maximilian Immanuel Brandtner <maxbr@linux.ibm.com>
Message-Id: <20250324144300.905535-1-maxbr@linux.ibm.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
Maximilian Immanuel Brandtner authored and Michael S. Tsirkin committed Apr 18, 2025
1 parent fbd3039 commit 5326ab7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/char/virtio_console.c
Original file line number Diff line number Diff line change
Expand Up @@ -1576,8 +1576,8 @@ static void handle_control_message(struct virtio_device *vdev,
break;
case VIRTIO_CONSOLE_RESIZE: {
struct {
__virtio16 rows;
__virtio16 cols;
__virtio16 rows;
} size;

if (!is_console_port(port))
Expand Down

0 comments on commit 5326ab7

Please sign in to comment.