Skip to content

Commit

Permalink
ASoC: soc-utils: Remove PAGE_SIZE compile-time constant assumption
Browse files Browse the repository at this point in the history
In pursuit of the goal of supporting boot-time page size selection,
remove use of PAGE_SIZE from the dummy_dma_hardware struct definition,
since the value is not known at compile-time for this config.

Given the previous parameters were "essentially random", let's just
hardcode them as 4K and 4K*2 to sidestep the need to boot-time patch the
structure with the selected PAGE_SIZE.

Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
Link: https://patch.msgid.link/20241021130308.3616451-1-ryan.roberts@arm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Ryan Roberts authored and Mark Brown committed Oct 21, 2024
1 parent 478fc2f commit 5337ff4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/soc/soc-utils.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ static const struct snd_pcm_hardware dummy_dma_hardware = {
.info = SNDRV_PCM_INFO_INTERLEAVED |
SNDRV_PCM_INFO_BLOCK_TRANSFER,
.buffer_bytes_max = 128*1024,
.period_bytes_min = PAGE_SIZE,
.period_bytes_max = PAGE_SIZE*2,
.period_bytes_min = 4096,
.period_bytes_max = 4096*2,
.periods_min = 2,
.periods_max = 128,
};
Expand Down

0 comments on commit 5337ff4

Please sign in to comment.