Skip to content

Commit

Permalink
phy: tegra: xusb: Only warn once about reset problems in .remove()
Browse files Browse the repository at this point in the history
The single difference between returning 0 and returning an error code in
a platform remove callback is that in the latter case the platform core
emits a warning about the error being ignored.

If reset_control_assert() fails there is already a warning, so suppress
the more generic (and less helpful) by returning 0 in
tegra_xusb_padctl_remove().

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220716145403.107703-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Uwe Kleine-König authored and Vinod Koul committed Aug 30, 2022
1 parent c77c185 commit 533e133
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/phy/tegra/xusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev)

padctl->soc->ops->remove(padctl);

return err;
return 0;
}

static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)
Expand Down

0 comments on commit 533e133

Please sign in to comment.