Skip to content

Commit

Permalink
drm/ast: Rename struct ast_cursor_plane to struct ast_plane
Browse files Browse the repository at this point in the history
Rename the plane structure struct ast_cursor_plane to struct
ast_plane as it will be used for the primary plane as well. No
functional changes.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Tested-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221013112923.769-6-tzimmermann@suse.de
  • Loading branch information
Thomas Zimmermann committed Oct 16, 2022
1 parent aa7c886 commit 537a1db
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 17 deletions.
15 changes: 9 additions & 6 deletions drivers/gpu/drm/ast/ast_drv.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ enum ast_tx_chip {
#define AST_DRAM_8Gx16 8

/*
* Cursor plane
* Hardware cursor
*/

#define AST_MAX_HWC_WIDTH 64
Expand All @@ -105,18 +105,21 @@ enum ast_tx_chip {
#define AST_HWC_SIGNATURE_HOTSPOTX 0x14
#define AST_HWC_SIGNATURE_HOTSPOTY 0x18

struct ast_cursor_plane {
/*
* Planes
*/

struct ast_plane {
struct drm_plane base;

struct drm_gem_vram_object *gbo;
struct iosys_map map;
u64 off;
};

static inline struct ast_cursor_plane *
to_ast_cursor_plane(struct drm_plane *plane)
static inline struct ast_plane *to_ast_plane(struct drm_plane *plane)
{
return container_of(plane, struct ast_cursor_plane, base);
return container_of(plane, struct ast_plane, base);
}

/*
Expand Down Expand Up @@ -170,7 +173,7 @@ struct ast_private {
uint32_t mclk;

struct drm_plane primary_plane;
struct ast_cursor_plane cursor_plane;
struct ast_plane cursor_plane;
struct drm_crtc crtc;
struct {
struct {
Expand Down
22 changes: 11 additions & 11 deletions drivers/gpu/drm/ast/ast_mode.c
Original file line number Diff line number Diff line change
Expand Up @@ -829,16 +829,16 @@ static void
ast_cursor_plane_helper_atomic_update(struct drm_plane *plane,
struct drm_atomic_state *state)
{
struct ast_cursor_plane *ast_cursor_plane = to_ast_cursor_plane(plane);
struct ast_plane *ast_plane = to_ast_plane(plane);
struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state,
plane);
struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state,
plane);
struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(new_state);
struct drm_framebuffer *fb = new_state->fb;
struct ast_private *ast = to_ast_private(plane->dev);
struct iosys_map dst_map = ast_cursor_plane->map;
u64 dst_off = ast_cursor_plane->off;
struct iosys_map dst_map = ast_plane->map;
u64 dst_off = ast_plane->off;
struct iosys_map src_map = shadow_plane_state->data[0];
unsigned int offset_x, offset_y;
u16 x, y;
Expand Down Expand Up @@ -910,9 +910,9 @@ static const struct drm_plane_helper_funcs ast_cursor_plane_helper_funcs = {

static void ast_cursor_plane_destroy(struct drm_plane *plane)
{
struct ast_cursor_plane *ast_cursor_plane = to_ast_cursor_plane(plane);
struct drm_gem_vram_object *gbo = ast_cursor_plane->gbo;
struct iosys_map map = ast_cursor_plane->map;
struct ast_plane *ast_plane = to_ast_plane(plane);
struct drm_gem_vram_object *gbo = ast_plane->gbo;
struct iosys_map map = ast_plane->map;

drm_gem_vram_vunmap(gbo, &map);
drm_gem_vram_unpin(gbo);
Expand All @@ -931,8 +931,8 @@ static const struct drm_plane_funcs ast_cursor_plane_funcs = {
static int ast_cursor_plane_init(struct ast_private *ast)
{
struct drm_device *dev = &ast->base;
struct ast_cursor_plane *ast_cursor_plane = &ast->cursor_plane;
struct drm_plane *cursor_plane = &ast_cursor_plane->base;
struct ast_plane *ast_plane = &ast->cursor_plane;
struct drm_plane *cursor_plane = &ast_plane->base;
size_t size;
struct drm_gem_vram_object *gbo;
struct iosys_map map;
Expand Down Expand Up @@ -963,9 +963,9 @@ static int ast_cursor_plane_init(struct ast_private *ast)
goto err_drm_gem_vram_vunmap;
}

ast_cursor_plane->gbo = gbo;
ast_cursor_plane->map = map;
ast_cursor_plane->off = off;
ast_plane->gbo = gbo;
ast_plane->map = map;
ast_plane->off = off;

/*
* Create the cursor plane. The plane's destroy callback will release
Expand Down

0 comments on commit 537a1db

Please sign in to comment.