Skip to content

Commit

Permalink
drm/i915/vlv: split DPIO init and reset
Browse files Browse the repository at this point in the history
We only need to init the reg offset for DPIO once, but we need to reset
DPIO at resume time and at init time.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Jesse Barnes authored and Daniel Vetter committed Dec 17, 2013
1 parent f42bb70 commit 5382f5f
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -1372,6 +1372,15 @@ static void intel_init_dpio(struct drm_device *dev)
DPLL_INTEGRATED_CRI_CLK_VLV);

DPIO_PHY_IOSF_PORT(DPIO_PHY0) = IOSF_PORT_DPIO;
}

static void intel_reset_dpio(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = dev->dev_private;

if (!IS_VALLEYVIEW(dev))
return;

/*
* From VLV2A0_DP_eDP_DPIO_driver_vbios_notes_10.docx -
* 6. De-assert cmn_reset/side_reset. Same as VLV X0.
Expand Down Expand Up @@ -10809,7 +10818,7 @@ void intel_modeset_init_hw(struct drm_device *dev)

intel_init_clock_gating(dev);

intel_init_dpio(dev);
intel_reset_dpio(dev);

mutex_lock(&dev->struct_mutex);
intel_enable_gt_powersave(dev);
Expand Down Expand Up @@ -10872,6 +10881,7 @@ void intel_modeset_init(struct drm_device *dev)
}

intel_init_dpio(dev);
intel_reset_dpio(dev);

intel_cpu_pll_init(dev);
intel_shared_dpll_init(dev);
Expand Down

0 comments on commit 5382f5f

Please sign in to comment.