Skip to content

Commit

Permalink
net: fddi: skfp: Use print_hex_dump() helper
Browse files Browse the repository at this point in the history
Use the print_hex_dump() helper, instead of open-coding the same operations.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Andy Shevchenko authored and David S. Miller committed Jan 25, 2020
1 parent 79ac522 commit 53c6770
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions drivers/net/fddi/skfp/skfddi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1520,22 +1520,8 @@ void mac_drv_tx_complete(struct s_smc *smc, volatile struct s_smt_fp_txd *txd)
#ifdef DUMPPACKETS
void dump_data(unsigned char *Data, int length)
{
int i, j;
unsigned char s[255], sh[10];
if (length > 64) {
length = 64;
}
printk(KERN_INFO "---Packet start---\n");
for (i = 0, j = 0; i < length / 8; i++, j += 8)
printk(KERN_INFO "%02x %02x %02x %02x %02x %02x %02x %02x\n",
Data[j + 0], Data[j + 1], Data[j + 2], Data[j + 3],
Data[j + 4], Data[j + 5], Data[j + 6], Data[j + 7]);
strcpy(s, "");
for (i = 0; i < length % 8; i++) {
sprintf(sh, "%02x ", Data[j + i]);
strcat(s, sh);
}
printk(KERN_INFO "%s\n", s);
print_hex_dump(KERN_INFO, "", DUMP_PREFIX_NONE, 16, 1, Data, min_t(size_t, length, 64), false);
printk(KERN_INFO "------------------\n");
} // dump_data
#else
Expand Down

0 comments on commit 53c6770

Please sign in to comment.