Skip to content

Commit

Permalink
null_blk: do not del gendisk with lightnvm
Browse files Browse the repository at this point in the history
The gendisk structure has not been initialized when using lightnvm.
Make sure to not delete it upon exit. Also make sure that we use the
appropriate disk_name at unregistration.

Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
  • Loading branch information
Matias Bjørling authored and Jens Axboe committed Nov 19, 2015
1 parent 5b40db9 commit 54514aa
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/block/null_blk.c
Original file line number Diff line number Diff line change
Expand Up @@ -435,12 +435,14 @@ static void null_del_dev(struct nullb *nullb)
list_del_init(&nullb->list);

if (use_lightnvm)
nvm_unregister(nullb->disk->disk_name);
del_gendisk(nullb->disk);
nvm_unregister(nullb->disk_name);
else
del_gendisk(nullb->disk);
blk_cleanup_queue(nullb->q);
if (queue_mode == NULL_Q_MQ)
blk_mq_free_tag_set(&nullb->tag_set);
put_disk(nullb->disk);
if (!use_lightnvm)
put_disk(nullb->disk);
cleanup_queues(nullb);
kfree(nullb);
}
Expand Down

0 comments on commit 54514aa

Please sign in to comment.