Skip to content

Commit

Permalink
sparc/sysrq: fix inconstistent help message of sysrq key
Browse files Browse the repository at this point in the history
Currently help message of /proc/sysrq-trigger highlight its
upper-case characters, like below:

      SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E)
      memory-full-oom-kill(F) kill-all-tasks(I) ...

this would confuse user trigger sysrq by upper-case character, which is
inconsistent with the real lower-case character registed key.

This inconsistent help message will also lead more confused when
26 upper-case letters put into use in future.

This patch fix spare sysrq key: "global-regs(y)"

Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
zhangwei(Jovi) authored and Linus Torvalds committed May 1, 2013
1 parent 90a102e commit 5452c7f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/sparc/kernel/process_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ static void sysrq_handle_globreg(int key)

static struct sysrq_key_op sparc_globalreg_op = {
.handler = sysrq_handle_globreg,
.help_msg = "global-regs(Y)",
.help_msg = "global-regs(y)",
.action_msg = "Show Global CPU Regs",
};

Expand Down Expand Up @@ -364,7 +364,7 @@ static void sysrq_handle_globpmu(int key)

static struct sysrq_key_op sparc_globalpmu_op = {
.handler = sysrq_handle_globpmu,
.help_msg = "global-pmu(X)",
.help_msg = "global-pmu(x)",
.action_msg = "Show Global PMU Regs",
};

Expand Down

0 comments on commit 5452c7f

Please sign in to comment.