Skip to content

Commit

Permalink
drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & fro…
Browse files Browse the repository at this point in the history
…m second arg

Changed function pointer use from non-majority address-of style
to majority short form without & via:

grep -rPl "\btasklet_init\s*\([^,\)]+,\s*\&" drivers/isdn | while read file ; do \
        perl -i -e 'local $/; while (<>) { s@(\btasklet_init\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
done

Compile tested allyesconfig x86

Signed-off-by: Joe Perches <joe@perches.com>

 drivers/isdn/gigaset/bas-gigaset.c |    4 ++--
 drivers/isdn/gigaset/common.c      |    2 +-
 drivers/isdn/gigaset/interface.c   |    2 +-
 drivers/isdn/gigaset/ser-gigaset.c |    2 +-
 drivers/isdn/gigaset/usb-gigaset.c |    2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Joe Perches authored and David S. Miller committed Nov 19, 2009
1 parent 386e50c commit 5452fee
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions drivers/isdn/gigaset/bas-gigaset.c
Original file line number Diff line number Diff line change
Expand Up @@ -2117,7 +2117,7 @@ static int gigaset_initbcshw(struct bc_state *bcs)
return 0;
}
tasklet_init(&ubc->sent_tasklet,
&write_iso_tasklet, (unsigned long) bcs);
write_iso_tasklet, (unsigned long) bcs);

spin_lock_init(&ubc->isoinlock);
for (i = 0; i < BAS_INURBS; ++i)
Expand All @@ -2138,7 +2138,7 @@ static int gigaset_initbcshw(struct bc_state *bcs)
ubc->shared0s = 0;
ubc->stolen0s = 0;
tasklet_init(&ubc->rcvd_tasklet,
&read_iso_tasklet, (unsigned long) bcs);
read_iso_tasklet, (unsigned long) bcs);
return 1;
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/isdn/gigaset/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ struct cardstate *gigaset_initcs(struct gigaset_driver *drv, int channels,
cs->ev_tail = 0;
cs->ev_head = 0;

tasklet_init(&cs->event_tasklet, &gigaset_handle_event,
tasklet_init(&cs->event_tasklet, gigaset_handle_event,
(unsigned long) cs);
cs->commands_pending = 0;
cs->cur_at_seq = 0;
Expand Down
2 changes: 1 addition & 1 deletion drivers/isdn/gigaset/interface.c
Original file line number Diff line number Diff line change
Expand Up @@ -584,7 +584,7 @@ void gigaset_if_init(struct cardstate *cs)
if (!drv->have_tty)
return;

tasklet_init(&cs->if_wake_tasklet, &if_wake, (unsigned long) cs);
tasklet_init(&cs->if_wake_tasklet, if_wake, (unsigned long) cs);

mutex_lock(&cs->mutex);
cs->tty_dev = tty_register_device(drv->tty, cs->minor_index, NULL);
Expand Down
2 changes: 1 addition & 1 deletion drivers/isdn/gigaset/ser-gigaset.c
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@ static int gigaset_initcshw(struct cardstate *cs)
dev_set_drvdata(&cs->hw.ser->dev.dev, cs);

tasklet_init(&cs->write_tasklet,
&gigaset_modem_fill, (unsigned long) cs);
gigaset_modem_fill, (unsigned long) cs);
return 1;
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/isdn/gigaset/usb-gigaset.c
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ static int gigaset_initcshw(struct cardstate *cs)
ucs->bulk_out_urb = NULL;
ucs->read_urb = NULL;
tasklet_init(&cs->write_tasklet,
&gigaset_modem_fill, (unsigned long) cs);
gigaset_modem_fill, (unsigned long) cs);

return 1;
}
Expand Down

0 comments on commit 5452fee

Please sign in to comment.