Skip to content

Commit

Permalink
USB: rio100: Push down the BKL
Browse files Browse the repository at this point in the history
The BKL is actually probably not needed as the mutex seems sufficient. If
so then a further patch to drop it would be a good followup.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alan Cox authored and Greg Kroah-Hartman committed Jul 21, 2008
1 parent f1b5a7f commit 5459215
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/usb/misc/rio500.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,7 @@ static int close_rio(struct inode *inode, struct file *file)
return 0;
}

static int
ioctl_rio(struct inode *inode, struct file *file, unsigned int cmd,
unsigned long arg)
static long ioctl_rio(struct file *file, unsigned int cmd, unsigned long arg)
{
struct RioCommand rio_cmd;
struct rio_usb_data *rio = &rio_instance;
Expand All @@ -116,6 +114,7 @@ ioctl_rio(struct inode *inode, struct file *file, unsigned int cmd,
int retries;
int retval=0;

lock_kernel();
mutex_lock(&(rio->lock));
/* Sanity check to make sure rio is connected, powered, etc */
if (rio->present == 0 || rio->rio_dev == NULL) {
Expand Down Expand Up @@ -254,6 +253,7 @@ ioctl_rio(struct inode *inode, struct file *file, unsigned int cmd,

err_out:
mutex_unlock(&(rio->lock));
unlock_kernel();
return retval;
}

Expand Down Expand Up @@ -433,7 +433,7 @@ file_operations usb_rio_fops = {
.owner = THIS_MODULE,
.read = read_rio,
.write = write_rio,
.ioctl = ioctl_rio,
.unlocked_ioctl = ioctl_rio,
.open = open_rio,
.release = close_rio,
};
Expand Down

0 comments on commit 5459215

Please sign in to comment.