Skip to content

Commit

Permalink
net: dsa: mv88e6xxx: fix 6085 frame mode masking
Browse files Browse the repository at this point in the history
The register bits used for the frame mode were masked with DSA (0x1)
instead of the mask value (0x3) in the 6085 implementation of
port_set_frame_mode. Fix this.

Fixes: 56995cb ("net: dsa: mv88e6xxx: Refactor CPU and DSA port setup")
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vivien Didelot authored and David S. Miller committed Jun 6, 2017
1 parent 286556c commit 5461bd4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/dsa/mv88e6xxx/port.c
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ int mv88e6085_port_set_frame_mode(struct mv88e6xxx_chip *chip, int port,
if (err)
return err;

reg &= ~PORT_CONTROL_FRAME_MODE_DSA;
reg &= ~PORT_CONTROL_FRAME_MASK;

switch (mode) {
case MV88E6XXX_FRAME_MODE_NORMAL:
Expand Down

0 comments on commit 5461bd4

Please sign in to comment.