Skip to content

Commit

Permalink
net: usb: Delete unnecessary checks before the macro call “dev_kfree_…
Browse files Browse the repository at this point in the history
…skb”

The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Markus Elfring authored and David S. Miller committed Aug 22, 2019
1 parent b7deac3 commit 5477fcc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 1 addition & 3 deletions drivers/net/usb/lg-vl600.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,7 @@ static void vl600_unbind(struct usbnet *dev, struct usb_interface *intf)
{
struct vl600_state *s = dev->driver_priv;

if (s->current_rx_buf)
dev_kfree_skb(s->current_rx_buf);

dev_kfree_skb(s->current_rx_buf);
kfree(s);

return usbnet_cdc_unbind(dev, intf);
Expand Down
6 changes: 2 additions & 4 deletions drivers/net/usb/rtl8150.c
Original file line number Diff line number Diff line change
Expand Up @@ -586,8 +586,7 @@ static void free_skb_pool(rtl8150_t *dev)
int i;

for (i = 0; i < RX_SKB_POOL_SIZE; i++)
if (dev->rx_skb_pool[i])
dev_kfree_skb(dev->rx_skb_pool[i]);
dev_kfree_skb(dev->rx_skb_pool[i]);
}

static void rx_fixup(unsigned long data)
Expand Down Expand Up @@ -946,8 +945,7 @@ static void rtl8150_disconnect(struct usb_interface *intf)
unlink_all_urbs(dev);
free_all_urbs(dev);
free_skb_pool(dev);
if (dev->rx_skb)
dev_kfree_skb(dev->rx_skb);
dev_kfree_skb(dev->rx_skb);
kfree(dev->intr_buff);
free_netdev(dev->netdev);
}
Expand Down

0 comments on commit 5477fcc

Please sign in to comment.