Skip to content

Commit

Permalink
scsi: target: core: Add initiatorname to NON_EXISTENT_LUN error
Browse files Browse the repository at this point in the history
The NON_EXISTENT_LUN error can be written without an error condition
on the initiator responsible. Adding the initiatorname to this message
will reduce the effort required to fix this when many initiators are
supported by a target.

This version ensures the initiator name is also printed on the same message
in transport_lookup_tmr_lun for consistency.

Link: https://lore.kernel.org/r/9b13bb2e1f52f1792cd81850ee95bf3781bb5363.1589759816.git.lance.digby@gmail.com
Reviewed-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Lance Digby <lance.digby@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
Lance Digby authored and Martin K. Petersen committed May 20, 2020
1 parent 1cdee00 commit 5482d56
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions drivers/target/target_core_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,10 @@ transport_lookup_cmd_lun(struct se_cmd *se_cmd, u64 unpacked_lun)
*/
if (unpacked_lun != 0) {
pr_err("TARGET_CORE[%s]: Detected NON_EXISTENT_LUN"
" Access for 0x%08llx\n",
" Access for 0x%08llx from %s\n",
se_cmd->se_tfo->fabric_name,
unpacked_lun);
unpacked_lun,
nacl->initiatorname);
return TCM_NON_EXISTENT_LUN;
}

Expand Down Expand Up @@ -174,9 +175,10 @@ int transport_lookup_tmr_lun(struct se_cmd *se_cmd, u64 unpacked_lun)

if (!se_lun) {
pr_debug("TARGET_CORE[%s]: Detected NON_EXISTENT_LUN"
" Access for 0x%08llx\n",
" Access for 0x%08llx for %s\n",
se_cmd->se_tfo->fabric_name,
unpacked_lun);
unpacked_lun,
nacl->initiatorname);
return -ENODEV;
}
se_cmd->se_dev = rcu_dereference_raw(se_lun->lun_se_dev);
Expand Down

0 comments on commit 5482d56

Please sign in to comment.