Skip to content

Commit

Permalink
Revert "sysfs: Kill nlink counting."
Browse files Browse the repository at this point in the history
This reverts commit 524b6c5.

It has shown to break userspace tools, which is not acceptable.

Reported-by: Jiri Slaby <jslaby@suse.cz>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Mar 8, 2012
1 parent 7b60a18 commit 54d20f0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
6 changes: 6 additions & 0 deletions fs/sysfs/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ static int sysfs_link_sibling(struct sysfs_dirent *sd)
struct rb_node **node = &sd->s_parent->s_dir.children.rb_node;
struct rb_node *parent = NULL;

if (sysfs_type(sd) == SYSFS_DIR)
sd->s_parent->s_dir.subdirs++;

while (*node) {
struct sysfs_dirent *pos;
int result;
Expand Down Expand Up @@ -123,6 +126,9 @@ static int sysfs_link_sibling(struct sysfs_dirent *sd)
*/
static void sysfs_unlink_sibling(struct sysfs_dirent *sd)
{
if (sysfs_type(sd) == SYSFS_DIR)
sd->s_parent->s_dir.subdirs--;

rb_erase(&sd->s_rb, &sd->s_parent->s_dir.children);
}

Expand Down
3 changes: 3 additions & 0 deletions fs/sysfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ static void sysfs_refresh_inode(struct sysfs_dirent *sd, struct inode *inode)
iattrs->ia_secdata,
iattrs->ia_secdata_len);
}

if (sysfs_type(sd) == SYSFS_DIR)
set_nlink(inode, sd->s_dir.subdirs + 2);
}

int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat)
Expand Down
1 change: 1 addition & 0 deletions fs/sysfs/sysfs.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ struct sysfs_open_dirent;
struct sysfs_elem_dir {
struct kobject *kobj;

unsigned long subdirs;
/* children rbtree starts here and goes through sd->s_rb */
struct rb_root children;
};
Expand Down

0 comments on commit 54d20f0

Please sign in to comment.