Skip to content

Commit

Permalink
xen/pvh: Use 'depend' instead of 'select'.
Browse files Browse the repository at this point in the history
The usage of 'select' means it will enable the CONFIG
options without checking their dependencies. That meant
we would inadvertently turn on CONFIG_XEN_PVHM while its
core dependency (CONFIG_PCI) was turned off.

This patch fixes the warnings and compile failures:

warning: (XEN_PVH) selects XEN_PVHVM which has unmet direct
dependencies (HYPERVISOR_GUEST && XEN && PCI && X86_LOCAL_APIC)

Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  • Loading branch information
Konrad Rzeszutek Wilk committed Jan 10, 2014
1 parent 0db6991 commit 54d44eb
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions arch/x86/xen/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,5 @@ config XEN_DEBUG_FS

config XEN_PVH
bool "Support for running as a PVH guest"
depends on X86_64 && XEN
select XEN_PVHVM
depends on X86_64 && XEN && XEN_PVHVM
def_bool n

0 comments on commit 54d44eb

Please sign in to comment.