Skip to content

Commit

Permalink
ASoC: samsung: Use devm_snd_soc_register_platform
Browse files Browse the repository at this point in the history
Replaced snd_soc_register_platform with devm_snd_soc_register_platform
in samsung_asoc_dma_platform_register(). This makes the function
samsung_asoc_dma_platform_unregister() redundant. This is removed and
all its users are updated.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Tushar Behera authored and Mark Brown committed May 21, 2014
1 parent c583883 commit 55313bd
Show file tree
Hide file tree
Showing 10 changed files with 6 additions and 32 deletions.
1 change: 0 additions & 1 deletion sound/soc/samsung/ac97.c
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,6 @@ static int s3c_ac97_remove(struct platform_device *pdev)
{
struct resource *irq_res;

samsung_asoc_dma_platform_unregister(&pdev->dev);
snd_soc_unregister_component(&pdev->dev);

irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
Expand Down
8 changes: 1 addition & 7 deletions sound/soc/samsung/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -445,16 +445,10 @@ EXPORT_SYMBOL_GPL(samsung_asoc_init_dma_data);

int samsung_asoc_dma_platform_register(struct device *dev)
{
return snd_soc_register_platform(dev, &samsung_asoc_platform);
return devm_snd_soc_register_platform(dev, &samsung_asoc_platform);
}
EXPORT_SYMBOL_GPL(samsung_asoc_dma_platform_register);

void samsung_asoc_dma_platform_unregister(struct device *dev)
{
snd_soc_unregister_platform(dev);
}
EXPORT_SYMBOL_GPL(samsung_asoc_dma_platform_unregister);

MODULE_AUTHOR("Ben Dooks, <ben@simtec.co.uk>");
MODULE_DESCRIPTION("Samsung ASoC DMA Driver");
MODULE_LICENSE("GPL");
1 change: 0 additions & 1 deletion sound/soc/samsung/dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,5 @@ void samsung_asoc_init_dma_data(struct snd_soc_dai *dai,
struct s3c_dma_params *playback,
struct s3c_dma_params *capture);
int samsung_asoc_dma_platform_register(struct device *dev);
void samsung_asoc_dma_platform_unregister(struct device *dev);

#endif
13 changes: 4 additions & 9 deletions sound/soc/samsung/dmaengine.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,13 @@ EXPORT_SYMBOL_GPL(samsung_asoc_init_dma_data);

int samsung_asoc_dma_platform_register(struct device *dev)
{
return snd_dmaengine_pcm_register(dev, &samsung_dmaengine_pcm_config,
SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME |
SND_DMAENGINE_PCM_FLAG_COMPAT);
return devm_snd_dmaengine_pcm_register(dev,
&samsung_dmaengine_pcm_config,
SND_DMAENGINE_PCM_FLAG_CUSTOM_CHANNEL_NAME |
SND_DMAENGINE_PCM_FLAG_COMPAT);
}
EXPORT_SYMBOL_GPL(samsung_asoc_dma_platform_register);

void samsung_asoc_dma_platform_unregister(struct device *dev)
{
return snd_dmaengine_pcm_unregister(dev);
}
EXPORT_SYMBOL_GPL(samsung_asoc_dma_platform_unregister);

MODULE_AUTHOR("Mark Brown <broonie@linaro.org>");
MODULE_DESCRIPTION("Samsung dmaengine ASoC driver");
MODULE_LICENSE("GPL");
2 changes: 0 additions & 2 deletions sound/soc/samsung/i2s.c
Original file line number Diff line number Diff line change
Expand Up @@ -1295,8 +1295,6 @@ static int samsung_i2s_remove(struct platform_device *pdev)
i2s->pri_dai = NULL;
i2s->sec_dai = NULL;

samsung_asoc_dma_platform_unregister(&pdev->dev);

return 0;
}

Expand Down
9 changes: 1 addition & 8 deletions sound/soc/samsung/idma.c
Original file line number Diff line number Diff line change
Expand Up @@ -413,13 +413,7 @@ static int asoc_idma_platform_probe(struct platform_device *pdev)
if (idma_irq < 0)
return idma_irq;

return snd_soc_register_platform(&pdev->dev, &asoc_idma_platform);
}

static int asoc_idma_platform_remove(struct platform_device *pdev)
{
snd_soc_unregister_platform(&pdev->dev);
return 0;
return devm_snd_soc_register_platform(&pdev->dev, &asoc_idma_platform);
}

static struct platform_driver asoc_idma_driver = {
Expand All @@ -429,7 +423,6 @@ static struct platform_driver asoc_idma_driver = {
},

.probe = asoc_idma_platform_probe,
.remove = asoc_idma_platform_remove,
};

module_platform_driver(asoc_idma_driver);
Expand Down
1 change: 0 additions & 1 deletion sound/soc/samsung/pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,6 @@ static int s3c_pcm_dev_remove(struct platform_device *pdev)
struct s3c_pcm_info *pcm = &s3c_pcm[pdev->id];
struct resource *mem_res;

samsung_asoc_dma_platform_unregister(&pdev->dev);
snd_soc_unregister_component(&pdev->dev);

pm_runtime_disable(&pdev->dev);
Expand Down
1 change: 0 additions & 1 deletion sound/soc/samsung/s3c2412-i2s.c
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,6 @@ static int s3c2412_iis_dev_probe(struct platform_device *pdev)

static int s3c2412_iis_dev_remove(struct platform_device *pdev)
{
samsung_asoc_dma_platform_unregister(&pdev->dev);
snd_soc_unregister_component(&pdev->dev);
return 0;
}
Expand Down
1 change: 0 additions & 1 deletion sound/soc/samsung/s3c24xx-i2s.c
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,6 @@ static int s3c24xx_iis_dev_probe(struct platform_device *pdev)

static int s3c24xx_iis_dev_remove(struct platform_device *pdev)
{
samsung_asoc_dma_platform_unregister(&pdev->dev);
snd_soc_unregister_component(&pdev->dev);
return 0;
}
Expand Down
1 change: 0 additions & 1 deletion sound/soc/samsung/spdif.c
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,6 @@ static int spdif_remove(struct platform_device *pdev)
struct samsung_spdif_info *spdif = &spdif_info;
struct resource *mem_res;

samsung_asoc_dma_platform_unregister(&pdev->dev);
snd_soc_unregister_component(&pdev->dev);

iounmap(spdif->regs);
Expand Down

0 comments on commit 55313bd

Please sign in to comment.