Skip to content

Commit

Permalink
usb: gadget: f_uac2: Add speed names to bInterval dbg/warn
Browse files Browse the repository at this point in the history
Add speed names for better clarity of dgb/warn messages from max packet
size/bInterval checks.

Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
Link: https://lore.kernel.org/r/20220127114331.41367-5-pavel.hofman@ivitera.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Pavel Hofman authored and Greg Kroah-Hartman committed Jan 31, 2022
1 parent 355a05d commit 554237f
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions drivers/usb/gadget/function/f_uac2.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,16 @@ static struct usb_string strings_fn[] = {
{ },
};

static const char *const speed_names[] = {
[USB_SPEED_UNKNOWN] = "UNKNOWN",
[USB_SPEED_LOW] = "LS",
[USB_SPEED_FULL] = "FS",
[USB_SPEED_HIGH] = "HS",
[USB_SPEED_WIRELESS] = "W",
[USB_SPEED_SUPER] = "SS",
[USB_SPEED_SUPER_PLUS] = "SS+",
};

static struct usb_gadget_strings str_fn = {
.language = 0x0409, /* en-us */
.strings = strings_fn,
Expand Down Expand Up @@ -745,12 +755,12 @@ static int set_ep_max_packet_size_bint(struct device *dev, const struct f_uac2_o

if (max_size_bw <= max_size_ep)
dev_dbg(dev,
"%s: Will use maxpctksize %d and bInterval %d\n",
dir, max_size_bw, bint);
"%s %s: Would use maxpctksize %d and bInterval %d\n",
speed_names[speed], dir, max_size_bw, bint);
else {
dev_warn(dev,
"%s: Req. maxpcktsize %d at bInterval %d > max ISOC %d, may drop data!\n",
dir, max_size_bw, bint, max_size_ep);
"%s %s: Req. maxpcktsize %d at bInterval %d > max ISOC %d, may drop data!\n",
speed_names[speed], dir, max_size_bw, bint, max_size_ep);
max_size_bw = max_size_ep;
}

Expand Down

0 comments on commit 554237f

Please sign in to comment.