Skip to content

Commit

Permalink
dma-buf/sw_sync: Replace all non-returning strlcpy with strscpy
Browse files Browse the repository at this point in the history
strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230523021943.2406847-1-azeemshaikh38@gmail.com
  • Loading branch information
Azeem Shaikh authored and Sumit Semwal committed May 24, 2023
1 parent 6a038f0 commit 5565a8e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/dma-buf/sw_sync.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ static struct sync_timeline *sync_timeline_create(const char *name)

kref_init(&obj->kref);
obj->context = dma_fence_context_alloc(1);
strlcpy(obj->name, name, sizeof(obj->name));
strscpy(obj->name, name, sizeof(obj->name));

obj->pt_tree = RB_ROOT;
INIT_LIST_HEAD(&obj->pt_list);
Expand Down

0 comments on commit 5565a8e

Please sign in to comment.