Skip to content

Commit

Permalink
net: atl1c: Change variable type to bool
Browse files Browse the repository at this point in the history
The variable ret is only assigned the values true and false.
The function atl1c_read_eeprom already returns bool. Change
ret type to bool.

The simplified semantic patch that find this problem is as
follows (http://coccinelle.lip6.fr/):

@exists@
type T;
identifier b;
@@
- T
+ bool
  b = ...;
  ... when any
  b = \(true\|false\)

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Peter Senna Tschudin authored and David S. Miller committed Oct 3, 2013
1 parent 99ebe9f commit 5570563
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/atheros/atl1c/atl1c_hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ static int atl1c_get_permanent_address(struct atl1c_hw *hw)
bool atl1c_read_eeprom(struct atl1c_hw *hw, u32 offset, u32 *p_value)
{
int i;
int ret = false;
bool ret = false;
u32 otp_ctrl_data;
u32 control;
u32 data;
Expand Down

0 comments on commit 5570563

Please sign in to comment.