Skip to content

Commit

Permalink
mmc: sdhci-milbeaut: Remove redundant platform_get_irq error message
Browse files Browse the repository at this point in the history
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20200116144322.57308-1-yuehaibing@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
YueHaibing authored and Ulf Hansson committed Jan 20, 2020
1 parent 1215c02 commit 557c031
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/mmc/host/sdhci-milbeaut.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,8 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev)
struct f_sdhost_priv *priv;

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(dev, "%s: no irq specified\n", __func__);
if (irq < 0)
return irq;
}

host = sdhci_alloc_host(dev, sizeof(struct f_sdhost_priv));
if (IS_ERR(host))
Expand Down

0 comments on commit 557c031

Please sign in to comment.