Skip to content

Commit

Permalink
mfd: Fixed gpio polarity of omap-usb gpio USB-phy reset
Browse files Browse the repository at this point in the history
With commit 1940316 a main part of ehci-omap.c moved to
drivers/mfd/omap-usb-host.c created by commit 17cdd29.
Due to this reorganisation the polarity used to reset the
external USB phy changed and USB host doesn't recognize
any devices.

Signed-off-by: Juergen Kilb <J.Kilb@phytec.de>
Acked-by: Felipe Balbi <balbi@ti.com>
Tested-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Juergen Kilb authored and Samuel Ortiz committed May 11, 2011
1 parent 9f381a6 commit 557f447
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/mfd/omap-usb-host.c
Original file line number Diff line number Diff line change
Expand Up @@ -717,14 +717,14 @@ static int usbhs_enable(struct device *dev)
gpio_request(pdata->ehci_data->reset_gpio_port[0],
"USB1 PHY reset");
gpio_direction_output
(pdata->ehci_data->reset_gpio_port[0], 1);
(pdata->ehci_data->reset_gpio_port[0], 0);
}

if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1])) {
gpio_request(pdata->ehci_data->reset_gpio_port[1],
"USB2 PHY reset");
gpio_direction_output
(pdata->ehci_data->reset_gpio_port[1], 1);
(pdata->ehci_data->reset_gpio_port[1], 0);
}

/* Hold the PHY in RESET for enough time till DIR is high */
Expand Down Expand Up @@ -904,11 +904,11 @@ static int usbhs_enable(struct device *dev)

if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[0]))
gpio_set_value
(pdata->ehci_data->reset_gpio_port[0], 0);
(pdata->ehci_data->reset_gpio_port[0], 1);

if (gpio_is_valid(pdata->ehci_data->reset_gpio_port[1]))
gpio_set_value
(pdata->ehci_data->reset_gpio_port[1], 0);
(pdata->ehci_data->reset_gpio_port[1], 1);
}

end_count:
Expand Down

0 comments on commit 557f447

Please sign in to comment.