Skip to content

Commit

Permalink
powerpc/numa: document topology_updates_enabled, disable by default
Browse files Browse the repository at this point in the history
Changing the NUMA associations for CPUs and memory at runtime is
basically unsupported by the core mm, scheduler etc. We see all manner
of crashes, warnings and instability when the pseries code tries to do
this. Disable this behavior by default, and document the switch a bit.

Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Nathan Lynch authored and Michael Ellerman committed Apr 20, 2019
1 parent 2d4d9b3 commit 558f864
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions arch/powerpc/mm/numa.c
Original file line number Diff line number Diff line change
Expand Up @@ -907,16 +907,22 @@ static int __init early_numa(char *p)
}
early_param("numa", early_numa);

static bool topology_updates_enabled = true;
/*
* The platform can inform us through one of several mechanisms
* (post-migration device tree updates, PRRN or VPHN) that the NUMA
* assignment of a resource has changed. This controls whether we act
* on that. Disabled by default.
*/
static bool topology_updates_enabled;

static int __init early_topology_updates(char *p)
{
if (!p)
return 0;

if (!strcmp(p, "off")) {
pr_info("Disabling topology updates\n");
topology_updates_enabled = false;
if (!strcmp(p, "on")) {
pr_warn("Caution: enabling topology updates\n");
topology_updates_enabled = true;
}

return 0;
Expand Down

0 comments on commit 558f864

Please sign in to comment.