Skip to content

Commit

Permalink
Revert "udp: increase inner ip header ID during segmentation"
Browse files Browse the repository at this point in the history
This reverts commit d6a8c36.
Next commit makes this commit unnecessary.

Acked-by: Cong Wang <amwang@redhat.com>
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Pravin B Shelar authored and David S. Miller committed Mar 25, 2013
1 parent 9cb690d commit 5594c32
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions net/ipv4/udp.c
Original file line number Diff line number Diff line change
Expand Up @@ -2304,8 +2304,7 @@ static struct sk_buff *skb_udp_tunnel_segment(struct sk_buff *skb,
struct sk_buff *segs = ERR_PTR(-EINVAL);
int mac_len = skb->mac_len;
int tnl_hlen = skb_inner_mac_header(skb) - skb_transport_header(skb);
int outer_hlen, id;
struct iphdr *iph;
int outer_hlen;
netdev_features_t enc_features;

if (unlikely(!pskb_may_pull(skb, tnl_hlen)))
Expand All @@ -2316,8 +2315,6 @@ static struct sk_buff *skb_udp_tunnel_segment(struct sk_buff *skb,
skb_reset_mac_header(skb);
skb_set_network_header(skb, skb_inner_network_offset(skb));
skb->mac_len = skb_inner_network_offset(skb);
iph = ip_hdr(skb);
id = ntohs(iph->id);

/* segment inner packet. */
enc_features = skb->dev->hw_enc_features & netif_skb_features(skb);
Expand All @@ -2332,8 +2329,6 @@ static struct sk_buff *skb_udp_tunnel_segment(struct sk_buff *skb,
int udp_offset = outer_hlen - tnl_hlen;

skb->mac_len = mac_len;
iph = (struct iphdr *)skb_inner_network_header(skb);
iph->id = htons(id++);

skb_push(skb, outer_hlen);
skb_reset_mac_header(skb);
Expand Down

0 comments on commit 5594c32

Please sign in to comment.