Skip to content

Commit

Permalink
netfilter: nf_tables: rename struct nft_set_estimate class field
Browse files Browse the repository at this point in the history
Use lookup as field name instead, to prepare the introduction of the
memory class in a follow up patch.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
  • Loading branch information
Pablo Neira Ayuso committed Feb 8, 2017
1 parent 1f48ff6 commit 55af753
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions include/net/netfilter/nf_tables.h
Original file line number Diff line number Diff line change
Expand Up @@ -244,11 +244,11 @@ enum nft_set_class {
* characteristics
*
* @size: required memory
* @class: lookup performance class
* @lookup: lookup performance class
*/
struct nft_set_estimate {
unsigned int size;
enum nft_set_class class;
enum nft_set_class lookup;
};

struct nft_set_ext;
Expand Down
12 changes: 6 additions & 6 deletions net/netfilter/nf_tables_api.c
Original file line number Diff line number Diff line change
Expand Up @@ -2401,9 +2401,9 @@ nft_select_set_ops(const struct nlattr * const nla[],
features &= NFT_SET_INTERVAL | NFT_SET_MAP | NFT_SET_TIMEOUT;
}

bops = NULL;
best.size = ~0;
best.class = ~0;
bops = NULL;
best.size = ~0;
best.lookup = ~0;

list_for_each_entry(ops, &nf_tables_set_ops, list) {
if ((ops->features & features) != features)
Expand All @@ -2413,15 +2413,15 @@ nft_select_set_ops(const struct nlattr * const nla[],

switch (policy) {
case NFT_SET_POL_PERFORMANCE:
if (est.class < best.class)
if (est.lookup < best.lookup)
break;
if (est.class == best.class && est.size < best.size)
if (est.lookup == best.lookup && est.size < best.size)
break;
continue;
case NFT_SET_POL_MEMORY:
if (est.size < best.size)
break;
if (est.size == best.size && est.class < best.class)
if (est.size == best.size && est.lookup < best.lookup)
break;
continue;
default:
Expand Down
2 changes: 1 addition & 1 deletion net/netfilter/nft_set_hash.c
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ static bool nft_hash_estimate(const struct nft_set_desc *desc, u32 features,
est->size = esize + 2 * sizeof(struct nft_hash_elem *);
}

est->class = NFT_SET_CLASS_O_1;
est->lookup = NFT_SET_CLASS_O_1;

return true;
}
Expand Down
2 changes: 1 addition & 1 deletion net/netfilter/nft_set_rbtree.c
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ static bool nft_rbtree_estimate(const struct nft_set_desc *desc, u32 features,
else
est->size = nsize;

est->class = NFT_SET_CLASS_O_LOG_N;
est->lookup = NFT_SET_CLASS_O_LOG_N;

return true;
}
Expand Down

0 comments on commit 55af753

Please sign in to comment.