Skip to content

Commit

Permalink
clk: qcom: msm8916: Fix return value check in qcom_apcs_msm8916_clk_p…
Browse files Browse the repository at this point in the history
…robe()

In case of error, the function dev_get_regmap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should be
replaced with NULL test.

Fixes: 81ac388 ("clk: qcom: Add APCS clock controller support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
  • Loading branch information
Wei Yongjun authored and Stephen Boyd committed Mar 12, 2018
1 parent 9903e41 commit 55c19ee
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/clk/qcom/apcs-msm8916.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,10 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev)
struct clk_regmap_mux_div *a53cc;
struct regmap *regmap;
struct clk_init_data init = { };
int ret;
int ret = -ENODEV;

regmap = dev_get_regmap(parent, NULL);
if (IS_ERR(regmap)) {
ret = PTR_ERR(regmap);
if (!regmap) {
dev_err(dev, "failed to get regmap: %d\n", ret);
return ret;
}
Expand Down

0 comments on commit 55c19ee

Please sign in to comment.