Skip to content

Commit

Permalink
IB/srp: send disconnect request without waiting for CM timewait exit
Browse files Browse the repository at this point in the history
Now that SRP recreates the CM ID, QP, and CQ for each connection,
there is no need to wait for the timewait state to complete.

Signed-off-by: Vu Pham <vu@mellanox.com>
Signed-off-by: David Dillow <dillowda@ornl.gov>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Roland Dreier <roland@purestorage.com>
  • Loading branch information
Vu Pham authored and Roland Dreier committed Dec 1, 2012
1 parent 73aa89e commit 55d9389
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/infiniband/ulp/srp/ib_srp.c
Original file line number Diff line number Diff line change
Expand Up @@ -481,12 +481,9 @@ static void srp_disconnect_target(struct srp_target_port *target)
if (srp_change_conn_state(target, false)) {
/* XXX should send SRP_I_LOGOUT request */

init_completion(&target->done);
if (ib_send_cm_dreq(target->cm_id, NULL, 0)) {
shost_printk(KERN_DEBUG, target->scsi_host,
PFX "Sending CM DREQ failed\n");
} else {
wait_for_completion(&target->done);
}
}
}
Expand Down Expand Up @@ -1664,7 +1661,6 @@ static int srp_cm_handler(struct ib_cm_id *cm_id, struct ib_cm_event *event)
shost_printk(KERN_ERR, target->scsi_host,
PFX "connection closed\n");

comp = 1;
target->status = 0;
break;

Expand Down

0 comments on commit 55d9389

Please sign in to comment.