Skip to content

Commit

Permalink
HID: fix memory leak on error path in debug code
Browse files Browse the repository at this point in the history
If hid_get_report() fails, we forgot to free the already allocated buffer
for debugging messages on error path. Fix that up.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jiri Kosina committed Jun 26, 2009
1 parent 38b7f49 commit 55dba52
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/hid/hid-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1100,8 +1100,10 @@ int hid_input_report(struct hid_device *hid, int type, u8 *data, int size, int i
hid_debug_event(hid, buf);

report = hid_get_report(report_enum, data);
if (!report)
if (!report) {
kfree(buf);
return -1;
}

/* dump the report */
snprintf(buf, HID_DEBUG_BUFSIZE - 1,
Expand Down

0 comments on commit 55dba52

Please sign in to comment.