Skip to content

Commit

Permalink
edac: ppc mpc85xx fix mc err detect
Browse files Browse the repository at this point in the history
Error found by Jeff Haran.

The error detect register is 0s when no errors are detected.  The check
code is incorrect, so reverse check sense.

Reported-by: Jeff Haran <jharan@Brocade.COM>
Signed-off-by: Dave Jiang <djiang@mvista.com>
Signed-off-by: Doug Thompson <dougthompson@xmission.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Dave Jiang authored and Linus Torvalds committed Apr 21, 2009
1 parent b298cec commit 55e5750
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/edac/mpc85xx_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci)
int row_index;

err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT);
if (err_detect)
if (!err_detect)
return;

mpc85xx_mc_printk(mci, KERN_ERR, "Err Detect Register: %#8.8x\n",
Expand Down

0 comments on commit 55e5750

Please sign in to comment.