Skip to content

Commit

Permalink
btrfs: use ASSERT to report logical error in cow_file_range()
Browse files Browse the repository at this point in the history
Use ASSERT to report logical error in cow_file_range(), also move it a
bit closer to when the num_bytes is derived.

The extent start could be (u64)-1 in some cases, the assert should catch
that we do not accidentally pass it to cow_file_range.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
  • Loading branch information
Anand Jain authored and David Sterba committed Mar 26, 2018
1 parent 3752d22 commit 566b176
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/btrfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,7 @@ static noinline int cow_file_range(struct inode *inode,

num_bytes = ALIGN(end - start + 1, blocksize);
num_bytes = max(blocksize, num_bytes);
ASSERT(num_bytes <= btrfs_super_total_bytes(fs_info->super_copy));

inode_should_defrag(BTRFS_I(inode), start, end, num_bytes, SZ_64K);

Expand Down Expand Up @@ -1008,8 +1009,6 @@ static noinline int cow_file_range(struct inode *inode,
}
}

BUG_ON(num_bytes > btrfs_super_total_bytes(fs_info->super_copy));

alloc_hint = get_extent_allocation_hint(inode, start, num_bytes);
btrfs_drop_extent_cache(BTRFS_I(inode), start,
start + num_bytes - 1, 0);
Expand Down

0 comments on commit 566b176

Please sign in to comment.