Skip to content

Commit

Permalink
spi: spi-cavium-thunderx: Add missing clk_disable_unprepare()
Browse files Browse the repository at this point in the history
Add the missing clk_disable_unprepare() before return in the probe
error handling case and remove.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Wei Yongjun authored and Mark Brown committed Aug 24, 2016
1 parent 7347a6c commit 568852b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/spi/spi-cavium-thunderx.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ static int thunderx_spi_probe(struct pci_dev *pdev,
return 0;

error:
clk_disable_unprepare(p->clk);
spi_master_put(master);
return ret;
}
Expand All @@ -93,6 +94,7 @@ static void thunderx_spi_remove(struct pci_dev *pdev)
if (!p)
return;

clk_disable_unprepare(p->clk);
/* Put everything in a known state. */
writeq(0, p->register_base + OCTEON_SPI_CFG(p));
}
Expand Down

0 comments on commit 568852b

Please sign in to comment.