Skip to content

Commit

Permalink
oprofile: Make op_name_from_perf_id() global
Browse files Browse the repository at this point in the history
Make op_name_from_perf_id() global so that we have a way for each
architecture to construct an oprofile name for op->cpu_type. We need to
remove the argument from the function prototype so that we can hide all
implementation details inside the function.

Signed-off-by: Matt Fleming <matt@console-pimps.org>
Signed-off-by: Robert Richter <robert.richter@amd.com>
  • Loading branch information
Matt Fleming authored and Robert Richter committed Oct 11, 2010
1 parent 84c7991 commit 5694633
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
6 changes: 4 additions & 2 deletions arch/arm/oprofile/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,10 @@ static void op_perf_stop(void)
}


static char *op_name_from_perf_id(enum arm_perf_pmu_ids id)
char *op_name_from_perf_id(void)
{
enum arm_perf_pmu_ids id = armpmu_get_pmu_id();

switch (id) {
case ARM_PERF_PMU_ID_XSCALE1:
return "arm/xscale1";
Expand Down Expand Up @@ -391,7 +393,7 @@ int __init oprofile_arch_init(struct oprofile_operations *ops)
ops->start = op_arm_start;
ops->stop = op_arm_stop;
ops->shutdown = op_arm_stop;
ops->cpu_type = op_name_from_perf_id(armpmu_get_pmu_id());
ops->cpu_type = op_name_from_perf_id();

if (!ops->cpu_type)
ret = -ENODEV;
Expand Down
4 changes: 4 additions & 0 deletions include/linux/oprofile.h
Original file line number Diff line number Diff line change
Expand Up @@ -185,4 +185,8 @@ int oprofile_add_data(struct op_entry *entry, unsigned long val);
int oprofile_add_data64(struct op_entry *entry, u64 val);
int oprofile_write_commit(struct op_entry *entry);

#ifdef CONFIG_PERF_EVENTS
char *op_name_from_perf_id(void);
#endif /* CONFIG_PERF_EVENTS */

#endif /* OPROFILE_H */

0 comments on commit 5694633

Please sign in to comment.