Skip to content

Commit

Permalink
i2c: at91: Handle return value of clk_prepare_enable
Browse files Browse the repository at this point in the history
clk_prepare_enable() can fail here and we must check its return value.
Also, add a missing clk_disable_unprepare().

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
  • Loading branch information
Arvind Yadav authored and Wolfram Sang committed Jun 19, 2017
1 parent 5c8e3ab commit 56a6cb8
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/i2c/busses/i2c-at91.c
Original file line number Diff line number Diff line change
Expand Up @@ -1083,12 +1083,16 @@ static int at91_twi_probe(struct platform_device *pdev)
dev_err(dev->dev, "no clock defined\n");
return -ENODEV;
}
clk_prepare_enable(dev->clk);
rc = clk_prepare_enable(dev->clk);
if (rc)
return rc;

if (dev->dev->of_node) {
rc = at91_twi_configure_dma(dev, phy_addr);
if (rc == -EPROBE_DEFER)
if (rc == -EPROBE_DEFER) {
clk_disable_unprepare(dev->clk);
return rc;
}
}

if (!of_property_read_u32(pdev->dev.of_node, "atmel,fifo-size",
Expand Down

0 comments on commit 56a6cb8

Please sign in to comment.