Skip to content

Commit

Permalink
timekeeping: remove xtime_update
Browse files Browse the repository at this point in the history
There are no more users of xtime_update aside from legacy_timer_tick(),
so fold it into that function and remove the declaration.

update_process_times() is now only called inside of the kernel/time/
code, so the declaration can be moved there.

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
  • Loading branch information
Arnd Bergmann committed Oct 30, 2020
1 parent f9a0153 commit 56cc7b8
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 20 deletions.
2 changes: 0 additions & 2 deletions include/linux/timekeeping.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ void timekeeping_init(void);
extern int timekeeping_suspended;

/* Architecture timer tick functions: */
extern void update_process_times(int user);
extern void xtime_update(unsigned long ticks);
extern void legacy_timer_tick(unsigned long ticks);

/*
Expand Down
22 changes: 20 additions & 2 deletions kernel/time/tick-legacy.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,28 @@

#include "tick-internal.h"

/**
* legacy_timer_tick() - advances the timekeeping infrastructure
* @ticks: number of ticks, that have elapsed since the last call.
*
* This is used by platforms that have not been converted to
* generic clockevents.
*
* If 'ticks' is zero, the CPU is not handling timekeeping, so
* only perform process accounting and profiling.
*
* Must be called with interrupts disabled.
*/
void legacy_timer_tick(unsigned long ticks)
{
if (ticks)
xtime_update(ticks);
if (ticks) {
raw_spin_lock(&jiffies_lock);
write_seqcount_begin(&jiffies_seq);
do_timer(ticks);
write_seqcount_end(&jiffies_seq);
raw_spin_unlock(&jiffies_lock);
update_wall_time();
}
update_process_times(user_mode(get_irq_regs()));
profile_tick(CPU_PROFILING);
}
16 changes: 0 additions & 16 deletions kernel/time/timekeeping.c
Original file line number Diff line number Diff line change
Expand Up @@ -2438,19 +2438,3 @@ void hardpps(const struct timespec64 *phase_ts, const struct timespec64 *raw_ts)
}
EXPORT_SYMBOL(hardpps);
#endif /* CONFIG_NTP_PPS */

/**
* xtime_update() - advances the timekeeping infrastructure
* @ticks: number of ticks, that have elapsed since the last call.
*
* Must be called with interrupts disabled.
*/
void xtime_update(unsigned long ticks)
{
raw_spin_lock(&jiffies_lock);
write_seqcount_begin(&jiffies_seq);
do_timer(ticks);
write_seqcount_end(&jiffies_seq);
raw_spin_unlock(&jiffies_lock);
update_wall_time();
}
1 change: 1 addition & 0 deletions kernel/time/timekeeping.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ static inline int sched_clock_suspend(void) { return 0; }
static inline void sched_clock_resume(void) { }
#endif

extern void update_process_times(int user);
extern void do_timer(unsigned long ticks);
extern void update_wall_time(void);

Expand Down

0 comments on commit 56cc7b8

Please sign in to comment.