Skip to content

Commit

Permalink
clk: hsdk-pll: Use managed of_clk_add_hw_provider()
Browse files Browse the repository at this point in the history
Use the managed `devm_of_clk_add_hw_provider()` instead of
`of_clk_add_hw_provider()`.

This makes sure the provider gets automatically removed on unbind and
allows to completely eliminate the drivers `remove()` callback.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20230410014502.27929-5-lars@metafoo.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
  • Loading branch information
Lars-Peter Clausen authored and Stephen Boyd committed Apr 10, 2023
1 parent c2e59c7 commit 56d144d
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions drivers/clk/clk-hsdk-pll.c
Original file line number Diff line number Diff line change
Expand Up @@ -346,13 +346,8 @@ static int hsdk_pll_clk_probe(struct platform_device *pdev)
return ret;
}

return of_clk_add_hw_provider(dev->of_node, of_clk_hw_simple_get,
&pll_clk->hw);
}

static void hsdk_pll_clk_remove(struct platform_device *pdev)
{
of_clk_del_provider(pdev->dev.of_node);
return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get,
&pll_clk->hw);
}

static void __init of_hsdk_pll_clk_setup(struct device_node *node)
Expand Down Expand Up @@ -431,6 +426,5 @@ static struct platform_driver hsdk_pll_clk_driver = {
.of_match_table = hsdk_pll_clk_id,
},
.probe = hsdk_pll_clk_probe,
.remove_new = hsdk_pll_clk_remove,
};
builtin_platform_driver(hsdk_pll_clk_driver);

0 comments on commit 56d144d

Please sign in to comment.