Skip to content

Commit

Permalink
net: mv643xx_eth: undo some opreations in mv643xx_eth_probe
Browse files Browse the repository at this point in the history
Cannot directly return platform_get_irq return irq, there
are operations that need to be undone.

Fixes: bf2b834 ("net: mv643xx_eth: use platform_get_irq() instead of platform_get_resource()")
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220316012444.2126070-1-chi.minghao@zte.com.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Minghao Chi authored and Jakub Kicinski committed Mar 17, 2022
1 parent f403443 commit 571703f
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/net/ethernet/marvell/mv643xx_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -3189,8 +3189,10 @@ static int mv643xx_eth_probe(struct platform_device *pdev)


irq = platform_get_irq(pdev, 0);
if (WARN_ON(irq < 0))
return irq;
if (WARN_ON(irq < 0)) {
err = irq;
goto out;
}
dev->irq = irq;

dev->netdev_ops = &mv643xx_eth_netdev_ops;
Expand Down

0 comments on commit 571703f

Please sign in to comment.