Skip to content

Commit

Permalink
pktgen: Add missing !flag parameters
Browse files Browse the repository at this point in the history
o FLOW_SEQ now can be disabled with pgset "flag !FLOW_SEQ"
o FLOW_SEQ and FLOW_RND are antonyms, as it's shown by pktgen_if_show()
o IPSEC now may be disabled

Note, that IPV6 is enabled with dst6/src6 parameters, not with
a flag parameter.

Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dmitry Safonov authored and David S. Miller committed Jan 24, 2018
1 parent d2ee797 commit 57a5749
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion net/core/pktgen.c
Original file line number Diff line number Diff line change
Expand Up @@ -1284,9 +1284,12 @@ static ssize_t pktgen_if_write(struct file *file,
else if (strcmp(f, "!SVID_RND") == 0)
pkt_dev->flags &= ~F_SVID_RND;

else if (strcmp(f, "FLOW_SEQ") == 0)
else if (strcmp(f, "FLOW_SEQ") == 0 || strcmp(f, "!FLOW_RND") == 0)
pkt_dev->flags |= F_FLOW_SEQ;

else if (strcmp(f, "FLOW_RND") == 0 || strcmp(f, "!FLOW_SEQ") == 0)
pkt_dev->flags &= ~F_FLOW_SEQ;

else if (strcmp(f, "QUEUE_MAP_RND") == 0)
pkt_dev->flags |= F_QUEUE_MAP_RND;

Expand All @@ -1301,6 +1304,9 @@ static ssize_t pktgen_if_write(struct file *file,
#ifdef CONFIG_XFRM
else if (strcmp(f, "IPSEC") == 0)
pkt_dev->flags |= F_IPSEC_ON;

else if (strcmp(f, "!IPSEC") == 0)
pkt_dev->flags &= ~F_IPSEC_ON;
#endif

else if (strcmp(f, "!IPV6") == 0)
Expand Down

0 comments on commit 57a5749

Please sign in to comment.