Skip to content

Commit

Permalink
KS8851: Add soft reset at probe time
Browse files Browse the repository at this point in the history
Issue a full soft reset at probe time.

This was reported by Doong Ping of Micrel, but no explanation of why this
is necessary or what bug it is fixing. Add it as it does not seem to hurt
the current driver and ensures that the device is in a known state when we
start setting it up.

Signed-off-by: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ben Dooks authored and David S. Miller committed Oct 21, 2009
1 parent 78abcb1 commit 57dada6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/ks8851.c
Original file line number Diff line number Diff line change
Expand Up @@ -1239,6 +1239,9 @@ static int __devinit ks8851_probe(struct spi_device *spi)
ndev->netdev_ops = &ks8851_netdev_ops;
ndev->irq = spi->irq;

/* issue a global soft reset to reset the device. */
ks8851_soft_reset(ks, GRR_GSR);

/* simple check for a valid chip being connected to the bus */

if ((ks8851_rdreg16(ks, KS_CIDER) & ~CIDER_REV_MASK) != CIDER_ID) {
Expand Down

0 comments on commit 57dada6

Please sign in to comment.