Skip to content

Commit

Permalink
bf561-coreb: BKL unneeded for open()
Browse files Browse the repository at this point in the history
According to Mike Frysinger:

	http://permalink.gmane.org/gmane.linux.kernel/699279

open() does not need the BKL, so take it back out.
  • Loading branch information
Jonathan Corbet committed Jul 2, 2008
1 parent a238b79 commit 57debdd
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions arch/blackfin/mach-bf561/coreb.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
#include <linux/device.h>
#include <linux/ioport.h>
#include <linux/module.h>
#include <linux/smp_lock.h>
#include <linux/uaccess.h>
#include <linux/fs.h>
#include <asm/dma.h>
Expand Down Expand Up @@ -195,9 +194,9 @@ static loff_t coreb_lseek(struct file *file, loff_t offset, int origin)
return ret;
}

/* No BKL needed here */
static int coreb_open(struct inode *inode, struct file *file)
{
lock_kernel();
spin_lock_irq(&coreb_lock);

if (coreb_status & COREB_IS_OPEN)
Expand All @@ -206,12 +205,10 @@ static int coreb_open(struct inode *inode, struct file *file)
coreb_status |= COREB_IS_OPEN;

spin_unlock_irq(&coreb_lock);
unlock_kernel();
return 0;

out_busy:
spin_unlock_irq(&coreb_lock);
unlock_kernel();
return -EBUSY;
}

Expand Down

0 comments on commit 57debdd

Please sign in to comment.