Skip to content

Commit

Permalink
ti-soc-thermal: Delete error messages for failed memory allocations i…
Browse files Browse the repository at this point in the history
…n ti_bandgap_build()

The script "checkpatch.pl" pointed information out like the following.

WARNING: Possible unnecessary 'out of memory' message

Thus remove such statements here.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Acked-by: Keerthy <j-keerthy@ti.com>
Tested-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
  • Loading branch information
Markus Elfring authored and Eduardo Valentin committed May 24, 2017
1 parent 748c23d commit 57e5211
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/thermal/ti-soc-thermal/ti-bandgap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1214,10 +1214,8 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
}

bgp = devm_kzalloc(&pdev->dev, sizeof(*bgp), GFP_KERNEL);
if (!bgp) {
dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
if (!bgp)
return ERR_PTR(-ENOMEM);
}

of_id = of_match_device(of_ti_bandgap_match, &pdev->dev);
if (of_id)
Expand All @@ -1226,10 +1224,8 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev)
/* register shadow for context save and restore */
bgp->regval = devm_kcalloc(&pdev->dev, bgp->conf->sensor_count,
sizeof(*bgp->regval), GFP_KERNEL);
if (!bgp->regval) {
dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n");
if (!bgp->regval)
return ERR_PTR(-ENOMEM);
}

i = 0;
do {
Expand Down

0 comments on commit 57e5211

Please sign in to comment.