Skip to content

Commit

Permalink
tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart
Browse files Browse the repository at this point in the history
This patch fixes below error reported by coccicheck

drivers/tty/serial/bcm63xx_uart.c:848:2-8: ERROR: missing clk_put;
clk_get on line 842 and execution via conditional on line 846

Fixes: ab4382d ("tty: move drivers/serial/ to drivers/tty/serial/")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/1587472306-105155-1-git-send-email-zou_wei@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Zou Wei authored and Greg Kroah-Hartman committed Apr 23, 2020
1 parent 2717769 commit 580d952
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/tty/serial/bcm63xx_uart.c
Original file line number Diff line number Diff line change
@@ -843,8 +843,10 @@ static int bcm_uart_probe(struct platform_device *pdev)
if (IS_ERR(clk) && pdev->dev.of_node)
clk = of_clk_get(pdev->dev.of_node, 0);

if (IS_ERR(clk))
if (IS_ERR(clk)) {
clk_put(clk);
return -ENODEV;
}

port->iotype = UPIO_MEM;
port->irq = res_irq->start;

0 comments on commit 580d952

Please sign in to comment.