Skip to content

Commit

Permalink
NFS: remove unused check for negative dentry
Browse files Browse the repository at this point in the history
This check has been hanging out since we used to have parallel paths to add
dentry in nfs_create(), but that hasn't been the case for some years.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
  • Loading branch information
Benjamin Coddington authored and Anna Schumaker committed Sep 20, 2019
1 parent 17fd6e4 commit 581057c
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions fs/nfs/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -1677,15 +1677,11 @@ nfs_add_or_obtain(struct dentry *dentry, struct nfs_fh *fhandle,
struct dentry *parent = dget_parent(dentry);
struct inode *dir = d_inode(parent);
struct inode *inode;
struct dentry *d = NULL;
struct dentry *d;
int error;

d_drop(dentry);

/* We may have been initialized further down */
if (d_really_is_positive(dentry))
goto out;

if (fhandle->size == 0) {
error = NFS_PROTO(dir)->lookup(dir, &dentry->d_name, fhandle, fattr, NULL);
if (error)
Expand Down

0 comments on commit 581057c

Please sign in to comment.