Skip to content

Commit

Permalink
openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_ac…
Browse files Browse the repository at this point in the history
…tion()'

All other error handling paths in this function go through the 'error'
label. This one should do the same.

Fixes: 9cc9a5c ("datapath: Avoid using stack larger than 1024.")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Christophe JAILLET authored and David S. Miller committed Sep 13, 2017
1 parent 9c08273 commit 5829e62
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion net/openvswitch/datapath.c
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,8 @@ static int ovs_nla_init_match_and_action(struct net *net,
if (!a[OVS_FLOW_ATTR_KEY]) {
OVS_NLERR(log,
"Flow key attribute not present in set flow.");
return -EINVAL;
error = -EINVAL;
goto error;
}

*acts = get_flow_actions(net, a[OVS_FLOW_ATTR_ACTIONS], key,
Expand Down

0 comments on commit 5829e62

Please sign in to comment.